DanielLeens commented on PR #11673: URL: https://github.com/apache/seatunnel/pull/11673#issuecomment-5216086103
+1 to @SEZ9's review — none of Issues 1-3 conflict with my own conclusion (no source-side blocker, the one open item was confirming a CI run completes on the final head). These are good robustness additions on top of that: Issue 2 in particular (the guard only checks `seatunnel-hadoop-aws`, not that the uber jar still relocates Jackson) is a real gap in defense-in-depth — a future change to the uber jar's shading could reintroduce the exact `NoSuchMethodError` this PR fixes, from the other direction, without the new CI step ever catching it. I'd fold Issues 1-3 in as non-blocking recommended fixes alongside my own suggestion (a small unit test for the masking regex), rather than blockers — the core one-line pom fix and the guard script as they stand today do correctly close the reported bug (#11655). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
