zhangshenghang commented on PR #11692: URL: https://github.com/apache/seatunnel/pull/11692#issuecomment-5220980480
Thanks for the detailed review. I have pushed commit b02135d1f addressing the remaining wording feedback: - Slack (en + zh): rewrote the webhooks_url table row so it no longer implies that webhooks_url participates in the message write path. The row now reads "The connector checks for this option during initialization; the message write path uses oauth_token and slack_channel to post via the Slack Web API.", matching the detailed option description. - DingTalk (en + zh): softened the secret option description to note that the signed DingTalk client is built lazily once per writer and reused for the writer lifetime rather than re-signed on every write, matching what DingTalkWriter.send() actually does. All six blocking issues (multi-table-write checkbox on DingTalk/Sentry/Slack, DingTalk/Slack data-type-mapping tables, OpenMldb graceful-degradation claim) plus the two non-blocking wording issues (Slack webhooks_url, DingTalk secret) should now be addressed. Issue 10 (placeholder credentials in DingTalk example) is a pre-existing concern from before this PR, so I have left it alone here to keep the diff focused. CI should re-run on the new head; happy to re-review once it lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
