DanielCarter-stack commented on PR #11692: URL: https://github.com/apache/seatunnel/pull/11692#issuecomment-5222691281
Thanks for the thorough review, @DanielLeens! All six high-severity blockers (Issues 1–6) are already fixed in the current branch `docs/connector-docs-batch-20260807-1` — every one of the three fabricated `support multiple table write` checkboxes is now unchecked, the DingTalk and Slack Data Type Mapping tables have been replaced with single-sentence descriptions that match the actual `SeaTunnelRow.toString()` / `String.valueOf(value)` behavior, and the OpenMldb docs no longer describe the nonexistent `toString()` fallback. For the low-severity nits: - Issue 7 (Slack `webhooks_url`): the current description states `checks for this option during initialization; the message write path uses oauth_token and slack_channel`, which matches the actual control flow. - Issue 8 (GoogleSheets): the source-vs-schema-driven framing has been reworded. - Issue 9 (DingTalk `secret`): the description now explicitly notes that the signed client is created lazily once per writer and reused, so it is not recomputed per send. - Issue 10 (DingTalk example credentials): left as-is per the `not required for this PR` note from the review. All 10 touched files end with a trailing newline. Ready for another review pass when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
