abdessalems commented on PR #11727:
URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5240680592
Thanks Daniel. Added the test for your Issue 3 in e9b25d8.
I verified it red/green before pushing, on the JDK 8 leg, same commit, with
the
test file unchanged between the two runs:
- with the `taskDone()` guard reverted, the new method fails on iteration 0 -
*"The task group future did not complete within 30s"* - while the existing
deploy-returns method still passes. That is exactly the blind spot you
described: the old assertion is already satisfied when `startedLatch` is
released, which is before `taskDone()` runs.
- with the guard restored, both methods pass, 30 iterations in 4.5s.
The new test calls `deployLocalTask()` directly so it can hold the
`TaskExecutionState` future that `deployTask(Data)` discards, and it keeps
the
remover thread racing until after that future has been observed - otherwise
the
window closes before `taskDone()` is reached. Completing exceptionally
counts as
completing; only never settling fails it.
Still to come: the follow-up issue for the underlying stale-`taskDone()` /
`executionContexts` race. I will link it here and on #11679 once it is filed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
