abdessalems commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5249420202
@nzw921rx Thanks for the review - good catch on the name. Renamed it to `startLatchReleased` in 79eebc5. You're right that `startSignalled` reads as "has the task started", when what it actually tracks is whether this particular worker has already counted down its slot of the latch. On modelling it through `result` instead: I looked at that and I don't think it works here. `result` stays null until `t.call()` returns, but the latch is released before `t.init()` on purpose - the deployer should be freed once the worker has resolved its context and is about to start, not once the task has produced a first result. Moving the release after `init()` would put a blocking `init()` back in the path that #11679 is about. `ProgressState` also has no "started" notion today, only `isDone()`/`isMadeProgress()`. The rename is the only change - no behaviour difference. Re-ran the module on Ubuntu/JDK 8 after it: `TaskDeployStaleContextRaceTest` 2/2, BUILD SUCCESS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
