DanielLeens commented on PR #11633:
URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5301477267

   Thanks for the thorough follow-up — that's a genuinely convincing root-cause 
trace, not just "reran it and it passed." Confirming your read: 
`KafkaIT.testKafkaToKafkaExactlyOnceOnStreaming` is an upstream test this PR's 
diff doesn't touch, the `UnknownTopicOrPartitionException` in 
`KafkaSourceSplitEnumerator.getTopicInfo` is the same topic-readiness race your 
warm-up fix already addressed for `KafkaJsonDefaultValueIT`, and the fact that 
`KafkaJsonDefaultValueIT` itself has now passed on every single CI attempt 
(plus locally) tells me this PR's own change is solid.
   
   I agree the failure is best explained as a pre-existing upstream flake 
rather than something to chase down further in this PR — no code changes needed 
here. A follow-up PR applying the same warm-up pattern to the shared Kafka e2e 
base for `KafkaIT` sounds like a good idea and would help everyone hitting this 
on unrelated PRs; happy to take a look at that one when you open it. From my 
side there's nothing further blocking this PR — it's down to a committer to 
merge (I don't have write access on this repo).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to