li3zhi4 commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5219755774
Thanks @DanielLeens for the tenth round and for the clear "no further code-level scrutiny warranted" call — and for the persistence through all nine prior rounds; the allowlist inversion was absolutely the right structural fix. All carryover issues are now closed. The one residual item, **Issue 3 (narrowed, Low)**, is fixed on the new head `73989d5fb`: the "Affected component" line in both `incompatible-changes.md` (EN + ZH) no longer claims "every connector using format = json"; it now lists the connectors that actually construct the `CatalogTable`-aware deserializer (Kafka, Pulsar, HTTP, GraphQL, MQTT, RocketMQ, Amazon SQS, Google Sheets, RabbitMQ, Redis, the File connector outside merge-partition mode, and the Debezium/Canal/Ogg/Maxwell CDC wrappers) and explicitly notes the File-connector merge-partition exception (partition columns are resolved from the file path at read time and cannot be expressed through a catalog table). Remaining items are as you outlined and out of the author's hands: - **CI**: the fork's Actions run for `1335d0be1` was still queued at your review; the new head `73989d5fb` (docs-only, +2/-2, no production code touched) will get its own run. I'll report the `kafka-connector-it` result once it concludes. - **Issue 4 (PR #11634 overlap)**: deferring to the committers, as you suggested — happy to close #11634 as superseded once this merges. Branch is up to date with `dev`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
