goutamadwant commented on code in PR #11818:
URL: https://github.com/apache/seatunnel/pull/11818#discussion_r3790074248
##########
seatunnel-engine/seatunnel-engine-ui/src/service/job/index.ts:
##########
@@ -20,7 +20,7 @@ import type { Job, JobPage } from './types'
export const getRunningJobs = (page: number, rows: number) =>
get<JobPage>('/running-jobs/summary', {page: page, rows: rows})
-export const getFinishedJobs = (page: number, rows: number) =>
get<JobPage>(`/finished-jobs`, {page: page, rows: rows})
+export const getFinishedJobs = (page: number, rows: number) =>
get<JobPage>(`/finished-jobs/finished`, {page: page, rows: rows})
Review Comment:
This changes the page behavior, not just the endpoint. /finished-jobs
returns all terminal jobs, while /finished-jobs/finished returns only jobs with
the FINISHED status. As a result, failed, canceled, and savepoint-completed
jobs disappear from the UI, so users cannot inspect their errors or details.
I verified that /finished-jobs?page=1&rows=5 returns 200 on the current PR
head.
Please keep /finished-jobs here and reproduce the reported 500 against the
current dev branch. If the 500 still occurs, it should be fixed server-side
with a regression test for the record that triggers it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
