det101 commented on issue #11666: URL: https://github.com/apache/seatunnel/issues/11666#issuecomment-5310952531
@SEZ9 Thanks for the review questions. Answers based on the design already posted in https://github.com/apache/seatunnel/issues/11666#issuecomment-5210832660: 1. **Chart library**: Apache ECharts (Apache-2.0), only in `seatunnel-engine-ui`. No second chart library. 2. **Refresh / window**: Reuse the existing Job Detail Overview poll — **every 2s** for `/metrics/realtime/jobs/{id}/vertices|edges` while Overview is open and the job is running. Default window **3 minutes**, capped at **10 minutes**. Pinned series consume the same response; **no extra poll per pin**. 3. **Pin persistence**: Session-scoped only (current Job Detail visit). **No** `localStorage`. Clear when leaving Job Detail or when the job reaches a terminal state. Keep pins when closing the drawer or switching tabs on the same job page. 4. **Pin limit**: **6** series max; reject with a short message when exceeded. 5. **Chart vs table**: V1 **replaces** the series table below the drawer divider. The key-field summary above the divider stays. Overview adds a pinned chart panel between DAG and the existing summary table. 6. **Issue body truncation**: The full V1 scope is in the design comment above; please treat that comment as the source of truth for implementation. 7. **PR**: Yes — I am contributing this. After design alignment I will open an implementation PR for `seatunnel-engine-ui`. 8. **#11351 / #11352**: Agree. We will extract shared realtime-fetch + a shared live-chart component so those features can inject series without duplicating Overview polling. @nzw921rx Thanks for the layout thoughts. For V1 I still prefer a **minimal change** on the current Job Detail Overview (compact DAG + pin panel + drawer chart) so we can ship a bounded, reviewable slice and a reusable chart contract. A header-tab redesign / richer DAG flow animation fits better as a later phase under #11668 once the shared chart + fetch pieces land. DAG height in the local demo was already reduced (600px → 320px) to free space for the pin panel. Happy to adjust if maintainers want V1 to include a new Metrics tab instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
