SEZ9 commented on issue #11666: URL: https://github.com/apache/seatunnel/issues/11666#issuecomment-5366250516
Thanks everyone for moving this forward. @det101 — the updated screenshots (fresh rebuild with live curves) look good, and your answers on the review questions are clear: ECharts in `seatunnel-engine-ui` only, reusing the 2s Overview poll on the existing `/metrics/realtime` endpoints with no extra poll per pin, session-scoped pins capped at 6, and the drawer chart replacing the series table while keeping the key-field summary. I'm fine treating the design comment (https://github.com/apache/seatunnel/issues/11666#issuecomment-5210832660) as the source of truth for V1 scope. @nzw921rx — your points on layout scalability are valid, especially that adding more metric charts later will strain the current page and that header tabs / animated DAG flow could serve the broader #11668 effort better. That said, I agree with the phasing det101 proposed: ship a minimal, reviewable V1 on the current Job Detail Overview (compact DAG at 320px + pin panel + drawer chart), and treat the tab redesign and DAG flow animation as a later phase under #11668 once the shared realtime-fetch and live-chart pieces exist. Those shared components are exactly what will make a redesign — and the #11351 / #11352 features — easier to build on. @zhang-arvin — thanks for offering to help, but det101 has already posted the design and a working local demo and committed to opening the implementation PR, so this one is spoken for. If you'd like to contribute in this area, coordinating on the #11668 follow-up work would be very welcome. Concrete remaining asks: 1. @det101 — please open the V1 implementation PR for `seatunnel-engine-ui` as scoped above; keep the shared fetch + chart component extraction in it so follow-ups can reuse them. 2. @nzw921rx — if you're okay with the phasing, could you confirm here so we have explicit alignment? If you want to sketch the header-tab layout for the later phase, please do that under #11668 rather than expanding this issue's scope. Thanks all! <!-- streview-comment:432 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
