SEZ9 commented on PR #11398: URL: https://github.com/apache/seatunnel/pull/11398#issuecomment-5316849993
Thanks for the contribution! Summarizing what's still needed on the current head `5ac02727f834`: 1. **Vertex-id null gap in the guarded edge loop**: the new `edge != null` check isn't enough — `edge.getInputVertexId()` and `edge.getTargetVertexId()` can still be null before `.toString()` is called. Please handle that case as well. 2. **Broader null coverage in `JobDAGInfo.toJsonObject()`**: `jobId`, `envOptions`, and `vertexInfoMap` are still dereferenced without the null-safe treatment given to `pipelineEdges`, even though the no-arg constructor allows all fields to be null. Please apply the same guards there. 3. **PR description scope**: please either complete the coverage or narrow the description so it matches the actual null-safety changes in the diff. On the CI side, please enable CI in your fork following the instructions here (thanks @dybyte for the pointer): https://github.com/apache/seatunnel/pull/11398/checks?check_run_id=86324931510 — and please sync your branch with the latest `dev` so we can separate baseline CI noise from the code-side fixes. Happy to re-review as soon as a new revision is pushed. <!-- streview-comment:190 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
