surafel58 commented on PR #11827: URL: https://github.com/apache/seatunnel/pull/11827#issuecomment-5317719170
Done in 5d809f69. Expanded the prepareCommit() comment to state the idempotency assumption (a failed checkpoint flush replays from the last successful checkpoint on restart, which is safe because Prometheus remote-write is an idempotent upsert keyed by (labels, timestamp)) and to note that returning Optional.empty() is the non-2PC use of this hook, matching the sibling sinks. Comment-only change, no behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
