goutamadwant commented on PR #11896: URL: https://github.com/apache/seatunnel/pull/11896#issuecomment-5351603609
@zhang-arvin The behavior change is correct, but please add a regression test for the non-exactly-once snapshot path. A focused test can use a bounded `ChangeEventQueue`, consume through the HIGH watermark, and assert that no `MongodbStreamFetchTask` is created. I reproduced it this way: the previous code created one backfill task after HIGH, while the current head created none and completed. This directly protects the deadlock scenario from being reintroduced. I also ran the clean MongoDB CDC module suite on this head: 27 tests passed. +1 to @nzw921rx 's suggestion too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
