zhang-arvin commented on PR #11896: URL: https://github.com/apache/seatunnel/pull/11896#issuecomment-5372425066
@DanielLeens thanks for the thorough review! I have addressed Issue 1: - Removed the unused END watermark enqueue in the non-exactly-once branch — now it just returns after logging, consistent with sibling connectors (MySQL/Oracle/Postgres/SqlServer) - Updated the regression test to assert that the END watermark is **not** present in non-exactly-once mode, and the last event is the HIGH watermark - Added a comment explaining why the END watermark is not needed (the reader only watches for HIGH, and the stream split already starts at the low watermark) Ready for another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
