SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5366241005
Thanks @DanielLeens for both thorough re-reviews. On the approval: agreed with your scoping — your diff of `a87908b919..8b99594826f` showing zero matches on the Spark/translation paths confirms the Spark 3.5.8 content at `8b995948` is what you already verified under review `4943484037`. On the changes-requested blocker: accepted. Since you've confirmed everything else is byte-for-byte identical to the approved state, I'll narrowly fix the merge-conflict resolution in `IcebergSourceIT.java` to restore the previously-approved behavior you quoted. One ask: your review body appears cut off right after the "before" snippet — could you paste the remainder (the merged "after" code path that regressed), so I fix exactly what you flagged? Once the corrected resolution is pushed, I'll ping you for a fresh full re-review of the new head per the re-review protocol. Thanks again for catching this before merge. <!-- streview-comment:415 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
