hesam-oxe commented on PR #11077:
URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-5370168498
@DanielLeens @SEZ9 Both blockers fixed on the new head:
1. ✅ Identity-based dedup — groupByIdentity() drives each shared
writer's snapshotState/prepareCommit/abortPrepare/close exactly
once, then fans results back to all aliased identifiers
2. ✅ Restore state union — all SinkIdentifiers' checkpoint states
merged before calling restoreWriter
3. ✅ Raw type fixed — SeaTunnelSink<?, ?, ?, ?>
4. ✅ Tests added — testSharedDeduplicatedWriterLifecycleInvokedOnce
+ testRestoreMergesStateFromAllAliasedTables
5. ✅ Javadoc restored
6. ✅ Spotless clean, diff --check passes
7. ✅ Build SUCCESS — 397 tests, 0 failures
Ready for re-review! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
