davidzollo commented on PR #11077: URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-5476833571
I rechecked the current head `c044430043bb` against the two carried-forward blockers. For PR11077-F1, `DestinationKey.equals` and `hashCode` now include the connector implementation class, physical destination identifier, and replica index. Sinks without an identifier remain isolated by object identity. The public opt-in contract also requires every distinguishing connection coordinate and equivalent write schema, settings, and commit semantics. For PR11077-F2, `MultiTableSinkWriter.snapshotState` groups aliases by writer identity and persists exactly one canonical state entry per shared writer. `restoreWriter` retains the alias-state union only to support checkpoints written before this optimization. `testSharedWriterRoundTripRestoresOneCanonicalState` verifies that a checkpoint from the current implementation restores one state, while the legacy-state test verifies the compatibility path. No additional source change is warranted for these two items on this head. The PR is still blocked by its reported merge conflict; I have not attempted to resolve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
