SEZ9 commented on PR #11639: URL: https://github.com/apache/seatunnel/pull/11639#issuecomment-5385643891
@DanielLeens thanks for the thorough summary and re-verification — the description matches the change set, and I support the direction of moving Debezium ownership out of the shared `connector-cdc-base` jar into each connector's own jar. The remaining blockers are the two documentation issues you flagged in review 4945111316: 1. **Issue 2 (High)**: the third-party migration note in `docs/en` and `docs/zh` `incompatible-changes.md` omits the mandatory `io.debezium:debezium-core` shade exclusion. Please add it in both language versions so out-of-tree CDC connectors aren't exposed to the order-dependent class-resolution race against the patched `ChangeEventQueue`. 2. **Issue 1 (Medium)**: the same doc bullet claims `connector-cdc-base` ships zero `io.debezium` classes; please correct it to state that it still ships the five patched classes. Since the head is still `afb0fada4b164062ef719f273caff9ad1197428d`, neither is addressed yet. Concretely: please push a commit fixing both doc issues and then mark the PR ready for review — `Build` run `91769082988` is green, so nothing else is blocking on the CI side. I also agree with your drift analysis: no sync is required right now since nothing upstream touches the shade-filter chain this PR relies on. Once the docs commit lands, I'll do a fresh pass promptly. <!-- streview-comment:480 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
