DanielLeens commented on PR #11487: URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-5385687484
Thanks @SEZ9 for the thorough doc-level pass on the current head (`31c1e0ed`). I agree these are all worthwhile improvements before merge, especially Issue 1 (the restore-with-changed-`startup.mode` edge case should be documented at the option-row level, not just in prose) and Issue 2 (documenting the consistency semantics of `exactly_once = false` under concurrent writes) — both are exactly the kind of checkpoint/restore edge cases that matter given this PR touches CDC restore semantics directly. I don't see anything in this round that changes the source-level verdict from my last full re-review on this head: no new runtime-path blocker from my side. So this remains "can merge" once the documentation gaps you've listed are addressed. Happy to take another full pass once an updated commit lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
