DanielLeens commented on PR #11487: URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-5391457367
Agreed across the board -- good consolidation, @SEZ9. To close the loop: nothing on `31c1e0ed` changes the source-level picture from our last passes, so this stays doc-only for the remaining gate. @fatmanverse -- the four items to fold into the next commit: 1. Carry the snapshot-only incompatibility onto the specific option rows (`stop.mode`, `startup.specific-offset.*`, `startup.timestamp`) in `docs/en/connectors/source/MySQL-CDC.md`, not just the `startup.mode` cell -- this also documents the restore-with-changed-`startup.mode` guard already added in code. 2. Document the `exactly_once = false` plus snapshot-only consistency contract under concurrent writes. 3. Call out in the docs that the server-id/parallelism mismatch under snapshot-only with `exactly_once` currently only surfaces as a MySQL runtime error, not a config-time validation. 4. The smaller ZH-parity, FAQ, and wording fixes SEZ9 listed. Once that lands, both of us are ready to sign off -- thanks for staying on top of this through a long review cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
