DanielLeens commented on PR #11576: URL: https://github.com/apache/seatunnel/pull/11576#issuecomment-5385687802
Thanks @SEZ9 for the deep follow-up on the current head (`2418b576474e`) — appreciate you tracing the exact `useSslProtocol()` / `setUri()` behavior against the pinned `amqp-client` version. Issue 1 (the no-arg `useSslProtocol()` installing a trust-all TrustManager with no hostname verification) is the same blocker I flagged on 2026-08-06, and it is still open on this head, so my CHANGES_REQUESTED stands unchanged — this needs a verifying `SSLContext` plus `enableHostnameVerification()` before merge, since shipping an `ssl` option that silently doesn't verify certificates is worse than not offering one. The serialVersionUID point on `RabbitmqConfig` (Issue 3) is also worth taking seriously: this config is part of the source/sink object graph that gets Java-serialized into Zeta's stored execution plan and checkpoint state, so an explicit `serialVersionUID` would avoid an `InvalidClassException` on restore for anyone upgrading across this change. I'll do a full re-review of the whole diff once a new commit addressing these lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
