SEZ9 commented on PR #11576: URL: https://github.com/apache/seatunnel/pull/11576#issuecomment-5390959091
Thanks @DanielLeens — you're right on both points, and neither is fixed on the current head (`2418b576474e`). **Issue 1 (trust-all `useSslProtocol()`):** Agreed this is a merge blocker. I'll switch to a verifying `SSLContext` and call `enableHostnameVerification()` whenever `ssl = true`. One question before I push: is relying on the default JVM trust store acceptable for this PR, or would you like configurable truststore options included now? I'd prefer to keep the surface minimal and defer custom truststore config, but I'll follow your call. **Issue 3 (serialVersionUID on `RabbitmqConfig`):** Accepted. Since the config is Java-serialized into Zeta's execution plan and checkpoint state, I'll add an explicit `serialVersionUID` in the same commit to avoid `InvalidClassException` on restore across an upgrade. I'll also address the remaining earlier findings (the `queueDeclarePassive` error handling, the `uri` alias convention, the boolean field consistency and `declareQueue` visibility annotation, and the doc heading/example gaps) in the same push rather than trickling commits, then ping you here for the full re-review. The trust-store question above is the only thing blocking me from pushing. <!-- streview-comment:508 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
