corgy-w commented on PR #11942: URL: https://github.com/apache/seatunnel/pull/11942#issuecomment-5385731863
Thanks for the detailed review! Pushed `fbf1fad53c` addressing all 5 points: - **Issue 1 + 2**: `JobMetricsRunner` now computes the average rates over **milliseconds** (clamped to 1 ms) instead of whole seconds, and measures the elapsed time with the **monotonic `System.nanoTime()`** clock. The first run's rate is now the real per-second rate (`delta * 1000 / elapsedMillis`), and a wall-clock rollback can no longer produce a wrong/negative rate. - **Issue 3**: the first-run test now overwrites the private `lastRunTimeNanos` base right before `run()` via `ReflectionUtils.setField`, so the zero-elapsed path is exercised deterministically regardless of test speed. - **Issue 4**: the metrics-not-ready test now asserts all three `last*Count` fields stay `0L` and adds `verify(seaTunnelClient).getJobMetricsSummary(1L)`. - **Issue 5**: `orElse(-1L)` replaced with `orElseThrow(AssertionError)` naming the missing field. `JobClientTest`: 12/12 pass, spotless clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
