DanielLeens commented on PR #11942: URL: https://github.com/apache/seatunnel/pull/11942#issuecomment-5459168647
Quick CI-status correction on my own review: I wrote "the CI build check should be watched to green before merge (it was still pending at last check)" while the run was in flight. That run (fork `corgy-w/seatunnel`, run `32636335738`, head `fbf1fad5`) has since finished, and the apache-side `Build` pointer is now showing `FAILURE` rather than pending, so I want to correct the record. I pulled the actual job matrix rather than trusting the top-level rollup: every job that ran is `success`, and the sole reason the overall run is red is one job, `kafka-connector-it (8, ubuntu-latest)`, which shows `conclusion: cancelled` after running from 13:35 to 17:05 (about 3.5 hours) before being cut off. `kafka-connector-it` has no relationship to this PR's diff (`JobMetricsRunner`/`ClientExecuteCommand` in the CLI client module), so this reads as a stuck/timed-out job on an unrelated connector-IT lane, not a real test failure caused by this change. Net: there is no new code-level finding here, and my "Ready to merge after fixes" conclusion (no blockers on the crash fix itself) stands. The actionable next step is simply a job-level rerun of `kafka-connector-it (8, ubuntu-latest)` to clear the stuck/cancelled job; once that comes back green (or non-red), CI should no longer be a factor here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
