SEZ9 commented on PR #11718: URL: https://github.com/apache/seatunnel/pull/11718#issuecomment-5390959451
Thanks for the careful re-check, @DanielLeens. **Issue 5 (PR11718-F5): withdrawn.** You verified at `d73c2b90bfdf` that the `org.junit.jupiter.api.TestInstance` import is present (line 37) and the class-level PER_CLASS annotation is on line 51, so the Javadoc link to `TestInstance.Lifecycle#PER_CLASS` on line 117 resolves. My "likely" didn't survive contact with the actual file — thanks for pulling it. **Issue 2 (PR11718-F2): agreed with your framing.** Since all eight call sites in `PaimonWithS3IT` go through the overridden `executeJob(String)`, there's no functional gap today. Narrowing the Javadoc claim to "a submission via `executeJob(String)`" — rather than promising any future submission is automatically bounded — resolves my concern. **On the rest:** your triage matches mine. A follow-up commit covering 1, 2, and 6 as you proposed — best-effort in-container kill of the wedged client on the timeout path, the scoped Javadoc wording, and a note on the IDE/no-ForkedBooter caveat — would close this out. Findings 3, 4, 7, and 8 are non-blocking polish; fold them in or leave them, either is fine with me. If you'd rather land the follow-up in a separate PR, that also works — just say which way you're going. No correctness blockers from my side. <!-- streview-comment:510 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
