DanielLeens commented on PR #11718: URL: https://github.com/apache/seatunnel/pull/11718#issuecomment-5391416996
Thanks for closing the loop, @SEZ9 — glad Issue 5 and Issue 2 both landed on solid ground once we checked the actual file/call sites instead of reasoning from memory. On the open question: my preference is a follow-up commit on this same PR rather than a separate PR. Items 1, 2, and 6 all touch the same class (`PaimonWithS3IT.java`) that's already under review here, they're small (a Javadoc scoping tweak, a caveat sentence, and a best-effort in-container kill on the timeout path), and keeping them in one place avoids re-opening the whole call-chain/bytecode verification context in a second PR for what is, at bottom, documentation precision plus one small robustness addition. A separate PR only earns its keep if the in-container-kill piece turns out to need its own back-and-forth — if @loustler finds that gets involved, splitting it off at that point is fine too. Either way, there are no correctness blockers on my side at the current head (`d73c2b90bf`) — this PR is approved and ready to merge as-is; the follow-up is purely additional polish, not a gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
