DanielLeens commented on PR #11545: URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5391450191
CI update on the previously-queued run: it has finished, and it is red — a genuine, novel finding, not the `python3`-in-image issue from the last round. The fork run for this exact head (`43a8637a70`, run `32625150600`) completed with a straight compile failure, identical across all four `unit-test` matrix lanes (8/11/17 x ubuntu/windows all fail the same way) plus the connector-it jobs that share the reactor build: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile (default-testCompile) on project connector-python-e2e: Compilation failure [ERROR] .../connector-python-e2e/src/test/java/org/apache/seatunnel/e2e/connector/python/PythonIT.java:[82,15] error: cannot find symbol [ERROR] symbol: variable container [ERROR] location: class PythonIT ``` I pulled `PythonIT.java` from this exact head and confirmed the bug: `installPythonIfNecessary()` (the method added in the `3f53d74a2bec` commit I reviewed last round as correctly fixing the E2E-harness python3 gap) calls `container.execInContainer(...)`, but `PythonIT extends SeaTunnelContainer`, and `SeaTunnelContainer` has no field named `container` — the actual field is `protected GenericContainer<?> server` (`SeaTunnelContainer.java:91`). So this doesn't compile at all; it never ran on any platform, which is also why the failure is identical on every OS/JDK combination rather than looking like the windows-specific pattern from earlier rounds. This is a one-line fix (`container` -> `server` at `PythonIT.java:82`), but it means my last round's endorsement of that commit's logic was based on reading the code, not on a completed compile — the queued CI run hadn't come back yet at review time. Confirming this myself before the run finished would have caught it; noting that for next time. As the PR author, this is a self-check comment, not an approval — a write-capable maintainer still needs to review once this compiles and a full green run is obtained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
