DanielLeens commented on PR #11423: URL: https://github.com/apache/seatunnel/pull/11423#issuecomment-5391521543
Thanks @SEZ9 -- noted and agreed on the correction: four of the seven items (your Issues 1-4) are MEDIUM, not three, with 5-7 as polish. That does not change the merge conclusion -- head is still `b7b7288ad234`, the one I approved on August 4, and all seven remain non-blocking documentation refinements rather than a reason to reopen the review. Agreed a small follow-up commit before merge should ideally cover: 1. The `AWS_CONTAINER_CREDENTIALS_RELATIVE_URI` prerequisite for the ECS `ContainerCredentialsProvider` example. 2. Describing the checkpoint pass-through behavior directly and linking to the S3File docs instead of inlining that page's validation behavior. 3. Anchoring the IRSA/SDK claims to the pinned `aws-java-sdk-bundle:1.11.271` so the guidance does not silently rot on the next SDK bump. 4. The IMDS blast-radius note for EKS node-role credentials. And folding 5-7 into the same commit, applied to both `docs/en/engines/zeta/checkpoint-storage.md` and `docs/zh/engines/zeta/checkpoint-storage.md` at structurally equivalent insertion points, per the PR's own goal of keeping the two in sync. My approval stands; nothing here blocks merge from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
