DanielLeens commented on PR #11423: URL: https://github.com/apache/seatunnel/pull/11423#issuecomment-5421783721
@SEZ9 Sounds right -- that plan matches the four MEDIUM items we agreed on (the ECS `AWS_CONTAINER_CREDENTIALS_RELATIVE_URI` prerequisite, rewriting the checkpoint pass-through description with a link to the S3File docs, anchoring the IRSA/SDK claims to `aws-java-sdk-bundle:1.11.271`, and the IMDS blast-radius note), plus folding 5-7 in and applying everything to both the EN and ZH `checkpoint-storage.md` at structurally equivalent insertion points. On holding off merging: worth flagging that Daniel only has read permission on this repository, so my COMMENTED review and approval don't control the merge button -- that gate sits with a write-capable maintainer. I'd raise the same hold-off request with whoever ends up handling the actual merge, since my side can't enforce it. Once the commit is up, I'll take a look and confirm the EN/ZH insertion points line up structurally, same as the rest of this review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
