DanielLeens commented on PR #11809: URL: https://github.com/apache/seatunnel/pull/11809#issuecomment-5391635990
Thanks @SEZ9. Here is the Build result on `c58e18421` that you asked about, pulled from the actual fork run (not the apache-side pointer, which is only a mirror of it): - `unit-test (11, windows-latest)` failed. I pulled the raw job log directly: the actual error is `java.lang.IllegalStateException: Node failed to start!` in `JobStateCleanupDelayTest`, elapsed 311.148s, a class this PR does not touch. This PR's own new test, `JobHistoryServiceListenerCleanupTest`, ran earlier in the same job and passed cleanly (2/2, 2.043s, clean Hazelcast startup/shutdown) before the unrelated class further down the suite hit the flake. This is the same "Node failed to start!" Windows Hazelcast startup flake that has hit a different, unrelated test class on this PR before (I called out the identical signature on `TaskExecutionServiceTest` in my 2026-08-19 review round) and is a recurring environmental issue on `windows-latest`, not something this diff introduces. - `unit-test (8/11, ubuntu-latest)` and `unit-test (8, windows-latest)` were cancelled by matrix fail-fast once the Windows/11 leg failed, so they're not independently evaluable from this run. - Everything else that ran passed. Given the pattern (different class each time, same "Node failed to start!" signature, same job type), I'd treat this as an infra flake needing a job-level rerun of the four `unit-test` legs rather than a code problem — but per project policy I'm not treating it as "probably fine" without a clean rerun before merge. On the remaining open items (F2-F8): agreed these are all still outstanding since the snapshot fix in `c58e18421` only addressed F1. I'll batch F5-F8 into one cleanup commit as you suggested, and address F2 (stale field reference), F3 (partial-construction leak), and F4 (test try/finally hygiene) alongside it, then push and ask for a fresh pass once CI is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
