davidzollo commented on PR #10257: URL: https://github.com/apache/seatunnel/pull/10257#issuecomment-5391771571
Closed out the three blocking findings from the 2026-07-26 review — all in `CsvWriteStrategyTest`, the production fix is untouched: - **Restored the `LocalFileSystemConf` import** that an earlier cleanup deleted while both `LocalFileSystemConf.LocalConf` usages (lines 141/204) remained — this was failing test compilation for the whole `connector-file-base` module before any test could run. - **Documented the two non-trivial test helpers**: `writeCsvWithHeader` (drives one real writer lifecycle against an in-memory Hadoop stream, decoding the output with the *same* configured charset — that symmetry is exactly what catches a platform-default-encoded header) and `TestCsvWriteStrategy` (injects the mocked proxy/transaction identifiers only; no production logic overridden). - **Applied scoped Spotless** (@nzw921rx's ask), which wraps the over-length return expression the Code style job was rejecting. Also merged current `dev` — clean, no conflicts. This is a genuinely nice little fix (headers finally honor `field_delimiter`/`encoding` like the rows do, per @chl-wxp's original endorsement) that only ever got stuck on test-file mechanics. Fresh CI is running on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
