DanielLeens commented on PR #11029:
URL: https://github.com/apache/seatunnel/pull/11029#issuecomment-5412546290
Thanks @SEZ9 - quick confirmation pass on top of your reply, since nothing
changed on my end from my Aug 24 review.
**Head check:** confirmed still `075001b0b5a9366da74bcc37f1b16b08e08d21f7`,
matches what you noted.
**Issue 1 (restore `SNAPSHOT_ONLY`):** I re-traced this independently again
before replying, since your ask ("restore" vs "document away") is a real fork
in the fix. `OpengaussSourceOptions.STARTUP_MODE`
(`OpengaussSourceOptions.java:43-55`, current head) narrows the choice set to
`INITIAL, EARLIEST, LATEST`, while `PostgresSourceOptions.STARTUP_MODE`
(`PostgresSourceOptions.java:29-43`) keeps `INITIAL, SNAPSHOT_ONLY,
COMMITTED_OFFSET, EARLIEST, LATEST`. I also checked whether `SNAPSHOT_ONLY`
genuinely depends on Postgres-only behavior, since the class's own Javadoc
claims both dropped modes are "backed by PostgreSQL-specific behavior." That
claim doesn't hold up under tracing: `SnapshotOnlySplitAssigner` lives entirely
in the dialect-agnostic `connector-cdc-base` module, and
`IncrementalSource.java:324-331` gates it purely on `StartupMode`, with no call
into any Postgres-specific dialect method anywhere in that path.
`COMMITTED_OFFSET` is the one that's genuinely Postgres-specifi
c (it reads `pg_replication_slots`); `SNAPSHOT_ONLY` is not. So I agree with
your preference: restoring `SNAPSHOT_ONLY` in the OpenGauss choice set is the
correct fix, not documenting the drop away. This remains a blocker.
**Issue 3:** agreed, still non-blocking, same assessment as before.
**One item not yet called out explicitly in this thread:** I checked the
live merge status directly (`gh pr view --json mergeable,mergeStateStatus`),
and this branch currently has a real merge conflict against `dev` (`mergeable:
CONFLICTING`, `mergeStateStatus: DIRTY`), separate from the ordinary "behind
dev" staleness we've both flagged before as a CI-noise issue. That will need a
rebase/conflict resolution alongside the code fixes before this can go green
again.
Status from my side is unchanged: waiting on a revision that (a) restores
`SNAPSHOT_ONLY` for OpenGauss and updates the en/zh docs, and (b) resolves the
merge conflict against `dev`. I'll do a full re-review once that lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
