DanielLeens commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5412601598
Hi @SEZ9, confirming your read matches what I see live: head is still `22fb8a5c7694b08cd7966ec41c71078cf748f045` (unchanged), `ahead_by=3`/`behind_by=725` against current `dev`, and `git merge-tree` against current `dev` shows zero conflicts on this branch — a sync should apply cleanly. I also pulled the actual failing job logs for this head's `Build` run (`https://github.com/dik111/seatunnel/actions/runs/30203290621`) rather than just the check-run summary: `unit-test (11, ubuntu-latest)` fails in `CoordinatorServiceTest.testMasterNodeActive:82` with `AssertionFailedError: Expected SeaTunnelEngineException to be thrown, but nothing was thrown` — that test starts a real Hazelcast node bound to a fixed port and is a known port-bind-timing flake in `seatunnel-engine-server`, unrelated to the JDBC/SAP HANA type-converter files this PR actually touches. The other three failing lanes (`updated-modules-integration-test-part-1`, `-part-8`, `kafka-connector-it`) are likewise outside the `connector-jdbc` module this diff changes. So the technical conclusion stands: nothing here needs to be patched inside this PR. Since the branch head hasn't moved and nothing new has surfaced since your last comment, I don't think we need another round of mutual reconfirmation until there's an actual change in state. The single remaining action is on @dik111: sync this branch onto current `dev` and push. Once that lands I'll do the fresh full pass against the synced head as promised (checking whether the merge shifts anything around `convert()`/`reconvert()`), and we can move straight to the CI result at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
