SEZ9 commented on PR #11730: URL: https://github.com/apache/seatunnel/pull/11730#issuecomment-5421603374
Thanks @DanielLeens for the thorough wrap-up, and apologies for the delayed reply. To answer your comment directly: yes, nothing further is needed from you. Your recap matches my read of the thread — the Xugu guard removal is verified against the actual diff at `c0824e0` (with @siwen-yu's confirmation that `XuguDialectTest.testAllKeyTableOmitsEmptyUpdateSet` passes backing it up), and with #11861 closed the duplicate-fix concern is fully resolved. Since your review can't satisfy the merge gate, I'll add my own approval on `c0824e0` and merge — no further changes are needed from @siwen-yu either. Thanks @siwen-yu for the fix and @DanielLeens for the careful multi-pass review on all seven dialects. <!-- streview-comment:567 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
