SEZ9 commented on PR #11827: URL: https://github.com/apache/seatunnel/pull/11827#issuecomment-5421603730
Thanks for the ping, @DanielLeens — confirming: yes, this covers my point, and nothing further is needed from me on this PR. On the checkpoint-flush robustness concern (a transient outage failing checkpoints), the documentation added in 2ce10e84 — the new "Checkpoint Flush and Failure Handling" section (EN and ZH) noting that transient failures fail the checkpoint and pointing users at the engine's tolerableCheckpointFailureNumber — is the minimum I asked for. @surafel58's reasoning for deferring the bounded retry with backoff to the tracked follow-up also makes sense to me, since landing it separately avoids conflicts with this PR. So to answer the question from the status comment: no objection to merging this PR with the behavioral hardening handled in the follow-up, as long as it stays scoped as described and is picked up after this merges. Ready to merge from my side — thanks both for closing the loop. <!-- streview-comment:569 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
