SEZ9 commented on PR #11996: URL: https://github.com/apache/seatunnel/pull/11996#issuecomment-5469334105
Thanks @DanielLeens for the thorough review — tracing each changed variable back to its declaration to confirm standard `List`/`ArrayList` semantics is exactly the kind of diligence we appreciate, and your approval covering all five call sites gives us good confidence this is a safe, behavior-preserving cleanup. @corgy-w, the change looks good from a review-quality standpoint. Two remaining asks before we merge: 1. Please make sure CI finishes green and ping the thread once it does. 2. Could you confirm there are no other `size() > 0` emptiness checks left in these two connector modules? If there are, it would be nice to sweep them in this same PR so the cleanup is complete rather than partial — if you'd prefer to keep the scope as-is, that's fine too, just let us know. Once CI is confirmed passing, this is ready to merge from my side. Thanks both! <!-- streview-comment:686 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
