JeremyXin commented on PR #11924:
URL: https://github.com/apache/seatunnel/pull/11924#issuecomment-5475907866
Reviewed the latest head `7c1e180`.
### Merge Conclusion: Request changes
**Blocking: coordination with PR #11999**
Both this PR and #11999 fix the same issue (#11755) by modifying
`TaskExecutionService.java`.
We need to figure out how to handle the implementations of these two PRs —
please take a look at the details of #11999.
**Additional required fixes:**
1. Dead code in `closeTimerFlushTaskForGeneration`
(`TaskExecutionService.java`):
the `future != null` check after the null-return guard is unreachable.
Please simplify to `if (!future.isDone())`.
2. `taskAsyncFunctionFutureByGeneration` and `timerFlushFuturesByGeneration`
rely on
`cancelAsyncFunction(location, generation)` /
`cancelTimerFlushForTaskGroup(location, generation)`
to be called for cleanup. Please confirm these are reached on all
completion paths
(including exception paths), otherwise these maps could grow unbounded
under frequent restores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
