DanielLeens commented on issue #11769: URL: https://github.com/apache/seatunnel/issues/11769#issuecomment-5478145271
Thanks for taking the time to test this and for attaching the code you ran. I downloaded the ZIP and compared its scope with the current repair path before replying. The good news is that your field result is directionally useful: two weeks without the old failure suggests the fix direction around the JDBC sink lifecycle is probably right. But I would not treat this attachment as proof that `#11883` itself closes the issue yet, for two concrete reasons: 1. your note explicitly says the local code is not identical to `#11883`; 2. the ZIP changes five JDBC sink classes (`ConnectionPoolManager`, `JdbcConnectionProvider`, `JdbcOutputFormat`, `JdbcSinkWriter`, `SimpleJdbcConnectionPoolProviderProxy`), while current `#11883` is still the narrower PR under review. So the maintainer decision here stays the same for now: keep this issue open until we can validate the exact active fix path, not a broader local variant. The most useful next step is one of these: 1. validate the exact `#11883` branch, or a `dev` build that includes its final equivalent, against your workload and report the result; 2. if the extra local changes are the reason it became stable, share the minimal delta versus `#11883` so we can judge whether those changes belong in the upstream fix or should be split. The current source evidence still points to an open JDBC sink runtime path rather than only a config-syntax gap: `JdbcSinkWriter` still handles pool validation separately from generic datasource properties, `#11879` is only the regression-test path, and `#11883` remains the active functional-fix review path. So I see your result as encouraging evidence, but not closure evidence yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
