DanielLeens commented on PR #11494: URL: https://github.com/apache/seatunnel/pull/11494#issuecomment-5502443158
Thanks @nzw921rx for taking a look and for the `+1 LGTM`! For the record, since a couple of reviews landed close together on this thread: my own conclusion on this PR is unchanged and still stands at **APPROVED** (submitted 2026-08-04 on head `bccb2761b`). I re-verified that on 2026-08-26 after @SEZ9's latest full pass — none of that round's findings carried forward as a blocking item either. The two items worth the author's attention going forward are non-blocking follow-ups: - Issue 3: negative/corrupted `dataLength` not guarded in WAL record parsing - Issue 6: `loadAllKeys` still retaining full `IMapFileData` (including value bytes) rather than a key-only footprint Neither blocks merge on the current head. So from a source-review standpoint there's no new blocker here — the remaining step is just going through the normal merge process. Thanks again for the extra eyes on this one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
