moneycat957 commented on issue #10443: URL: https://github.com/apache/seatunnel/issues/10443#issuecomment-5502974903
Starting implementation. One decision I want to flag early rather than surprise you with at review time: this first PR will ship unit tests only, with no `connector-amazondocumentdb-e2e` module, and will not touch `seatunnel-e2e/seatunnel-connector-v2-e2e/pom.xml`. Reason: #11167 could ship an E2E module because Testcontainers provides `CosmosDBEmulatorContainer` for Microsoft's official emulator image. AWS publishes no DocumentDB emulator and DocumentDB is VPC-only, so a faithful E2E needs a live cluster inside a VPC. A plain `mongo` container would exercise the wire protocol but would prove nothing about the DocumentDB-specific behaviour this connector exists for (enforced `retryWrites=false`, TLS with the RDS CA bundle). This matches the 16 connectors in `dev` that ship without an E2E module — salesforce, slack, sentry, dingtalk, google-sheets, google-bigtable, tablestore, selectdb-cloud, snmp and others — all cloud services with no local emulator. `connector-snmp` landed this way on Aug 30. If you'd rather have a mongo-container E2E clearly labelled as a wire-protocol proxy only, say so and I'll add the module instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
