nzw921rx commented on code in PR #12081:
URL: https://github.com/apache/seatunnel/pull/12081#discussion_r3930859666
##########
seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/CheckpointStorageBenchmark.java:
##########
@@ -93,6 +93,9 @@ public void
checkpointPersistenceTransaction(CheckpointPersistenceBenchmarkWorkl
* independent job/pipeline counters that were initialized before
measurement. Counter setup,
* MapStore reload checks, result validation, and cleanup are not timed.
*
+ * <p>Each increment waits on the write-through file-backed MapStore WAL
append, so durable sync
Review Comment:
Do these really need to be reflected in the comments?
##########
docs/zh/engines/zeta/benchmark.md:
##########
@@ -202,6 +202,11 @@ java -jar seatunnel-benchmarks/target/benchmarks.jar
CheckpointStorageBenchmark
Barrier 传递、任务快照、ACK 等待、Fixture 生成、持久性校验和清理均不计入测量。每次
invocation 固定执行 100 个逻辑操作，并按单个操作归一化为 `us/op`；数值越低越好。
+上述两个隔离方法都走 write-through IMap MapStore 路径（`write-delay-seconds: 0`），因此每次
Review Comment:
Shouldn't this be reflected in the documentation of benchmark testing? A
more suitable approach is to conduct it in PR
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/monitor/CheckpointMonitorService.java:
##########
@@ -258,13 +257,26 @@ private void
removeInProgressIfExists(PipelineCheckpointOverview pipeline, long
pipeline.getInProgress().removeIf(cp -> cp.getCheckpointId() ==
checkpointId);
}
+ /**
Review Comment:
How much impact does this have on CV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
