DanielLeens commented on PR #12051: URL: https://github.com/apache/seatunnel/pull/12051#issuecomment-5558564206
Thanks for pushing this through, @CryoThrust — I pulled run `33960949015` directly (job logs, not just the summary) to check your read on the two failures myself rather than taking it at face value. Confirmed both are unrelated to this diff: - `all-connectors-it-7 (8, ubuntu-latest)`: the only failure in that shard is `AmazondynamodbIT.testAmazondynamodb` — `AssertionFailedError: table sink_table is empty`. That's an Amazon DynamoDB Local container/data-visibility issue in an entirely unrelated connector module. - `rocketmq-connector-it (11, ubuntu-latest)`: all 43 failures/errors trace back to `RocketMqConnectorException: ErrorCode:[ROCKETMQ-11] Failed to get topic min and max topic` and `waitConsumedOffsetsSynced` timeouts — a RocketMQ test-container connectivity flake, not a code issue, and again a module this PR's diff never touches. This PR only changes `CoordinatorServiceTest` under `seatunnel-engine-server` (test-only, no production code), and every check that could plausibly be affected by that — license/style, unit tests, and the engine-v2 suite — is green. There's no plausible mechanism by which a test-fixture change in `seatunnel-engine-server` could cause a DynamoDB or RocketMQ container to misbehave, so I'm treating these two as pre-existing environmental flakes rather than something introduced here. From my side there's no remaining code-level blocker — my last review already confirmed the fix is correct and deterministic, and this closes out the only open item (waiting on the real Build result). I'll leave the final "ignore vs. rerun those two IT jobs" call to a maintainer with rerun access, but as far as this PR's own content goes, I'm satisfied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
