DanielLeens commented on PR #12182: URL: https://github.com/apache/seatunnel/pull/12182#issuecomment-5583652914
Thanks for the correction, @SEPURI-SAI-KRISHNA — and for the detailed #12116 evidence trail on `transform-v2-it-part-1`. I re-verified against the fork's Actions API directly (job IDs + per-attempt timestamps, not just the check-run summary) rather than taking either of our earlier readings at face value, and here's where things actually stand right now. You were right about the original run (`run_attempt=1`): it genuinely had two failures, `engine-v2-it (11, ubuntu-latest)` (job `101784974087`) and `transform-v2-it-part-1 (11, ubuntu-latest)` (job `101784974271`), with `kudu-connector-it (8, ubuntu-latest)` cancelled as collateral. My original review only cited the `engine-v2-it` one — that was an incomplete reading on my part, thank you for catching it. Since then the picture has moved again because of your own rerun. Checking `run_attempt=2` (the current/live attempt) job-by-job: - `engine-v2-it (11, ubuntu-latest)` — job `101931398282`, started 03:52:03Z, completed 05:02:51Z: now **SUCCESS**. Your rerun confirms the original failure (`SinkErrorToMysqlIT` Awaitility `ConditionTimeout`) was indeed the environmental flake we both suspected, not something this diff caused. - `transform-v2-it-part-1 (11, ubuntu-latest)` — job `101931399121`, still **FAILURE** (same `TestFilterRowKindIT` symptom, same #12116 signature you documented). - `engine-v2-it (8)`, `transform-v2-it-part-1 (8)`, `kudu-connector-it (11)` — all green; `kudu-connector-it (8)` — cancelled (unchanged, collateral only). So, as of right now, live: this PR has exactly **one** outstanding failing job, `transform-v2-it-part-1 (11, ubuntu-latest)`, matching your #12116 diagnosis — not the one I originally cited (already resolved by your rerun) and not the two you cited a moment ago (since one of those two has since gone green). Nothing else in this review changes: the fix itself, the new unit tests, and the "no dev-sync needed" reasoning all still hold. A job-level rerun of just `transform-v2-it-part-1 (11, ubuntu-latest)` should be enough to get the required `Build` check green; from there a maintainer with write-level review permission can formally approve and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
