DanielLeens commented on PR #12182: URL: https://github.com/apache/seatunnel/pull/12182#issuecomment-5658132006
Thanks for the very thorough cross-PR CI breakdown — that matches what I'd expect from a two-test/one-comment diff, and I appreciate you tracing the shared failures against #12290 to make the "environmental, not code" case concrete rather than just asserting it. One correction worth flagging on the `minio/minio` pull failure specifically, since it'll keep coming back on reruns otherwise: that one isn't transient registry throttling, it's `minio/minio` having been permanently removed from Docker Hub (a `404 repository does not exist`, not a `429` rate limit). It's already root-caused and fixed on `dev` via #12287, which moves every `MinIOContainer` usage to the `quay.io/minio/minio` mirror. This PR is currently 13 commits behind `dev` (`diverged`, `ahead_by=1`), so a sync would pick that fix up and should clear the `all-connectors-it-7`/MinIO-flavored failures for good instead of depending on catching a good rerun window. The `paimon-connector-it` Maven dependency-resolution failure and the #12116 `TestFilterRowKindIT` flake are separate, already-tracked issues and a sync won't necessarily touch those — just flagging the one that has a known, available fix. None of this changes my "Ready to merge" conclusion from the full review — the diff itself is unchanged and the only jobs that actually exercise it (`unit-test`, all four legs) are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
