nzw921rx commented on code in PR #12232:
URL: https://github.com/apache/seatunnel/pull/12232#discussion_r3968654031
##########
seatunnel-connectors-v2/connector-firebase/src/main/java/org/apache/seatunnel/connectors/seatunnel/firebase/sink/FirebaseSink.java:
##########
@@ -15,45 +15,34 @@
* limitations under the License.
*/
-package org.apache.seatunnel.connectors.seatunnel.snmp.sink;
+package org.apache.seatunnel.connectors.seatunnel.firebase.sink;
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
import org.apache.seatunnel.api.sink.SinkWriter;
import org.apache.seatunnel.api.table.catalog.CatalogTable;
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
-import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
import
org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
-import org.apache.seatunnel.connectors.seatunnel.snmp.config.SnmpSinkConfig;
-import org.apache.seatunnel.connectors.seatunnel.snmp.config.SnmpSinkOptions;
-import java.util.Optional;
+import java.io.IOException;
-/** SeaTunnel sink that applies input rows through SNMPv2c SET requests. */
-public final class SnmpSink extends AbstractSimpleSink<SeaTunnelRow, Void> {
-
- private final SnmpSinkConfig config;
+public class FirebaseSink extends AbstractSimpleSink<SeaTunnelRow, Void> {
Review Comment:
thanks your contribution
use `TableSinkFactory` need impl `getWriteCatalogTable()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
