DanielLeens commented on issue #12223: URL: https://github.com/apache/seatunnel/issues/12223#issuecomment-5602963172
The proposed boundary is reasonable, but it needs one owner and one testable adapter contract. I checked the current Oracle CDC module and the open PR set: there is no existing OpenLogReplicator adapter or competing OLR PR. @cjw0810, please publish the implementation as a draft PR or a branch with the adapter seam and the exact protocol contract before separate test work starts. The first implementation remains an adapter behind `Oracle-CDC`; it must not add a second source type or alter the LogMiner path. @CryoThrust, the focused fake-endpoint coverage is useful, but please do not open an independent test-only PR against an unpublished protocol shape. Once the adapter contract is visible, keep the test slice to deterministic INFO, START, and CONTINUE framing; snapshot-watermark and checkpoint-index recovery; INSERT, UPDATE_BEFORE, UPDATE_AFTER, and DELETE mapping; disconnect/reconnect; and malformed responses. The contract must explicitly state retry and failure behavior, and it must preserve the existing source split and checkpoint interfaces. Oracle 19c and real OLR verification remains environment-specific evidence, not a substitute for this deterministic coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
