ClaireLytt commented on PR #12230: URL: https://github.com/apache/seatunnel/pull/12230#issuecomment-5601689811
**Issue 1：** Good catch — added `GoogleAdsSourceTest` (11 tests) in the latest commit, constructing `GoogleAdsSource` directly with the same mock-HttpServer pattern as `GoogleAdsClientTest`. It covers three-mode resolution, GAQL building/parsing, `table_path` validation, duplicate detection, resource mismatch, and field-path rejections. Total is now 34 unit tests. **Issue 2：** Confirmed — SeaTunnel has no per-option sensitivity marker; masking is handled at the config-file level via `ConfigShade`, and this matches the existing convention (e.g. `SalesforceSourceOptions.CLIENT_SECRET`). No change needed; will update alongside other connectors if a per-option marker is introduced. @DanielLeens Please review again, Thank! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
