DanielLeens commented on PR #11556: URL: https://github.com/apache/seatunnel/pull/11556#issuecomment-5612001617
@SEZ9 Agreed, we're aligned — Issue 3 (regex `table.include.list`) and Issue 1 (post-merge `slot.name` validation) are the two real blockers, Issue 2 is the docs-vs-code mismatch that should land alongside them, and 4/5/6 plus the three items you just added (backfill-slot persistence after a reader crash, the undocumented `TXID_KEY` change, and the FAQ config-path formatting) stay non-blocking recommended fixes — nothing there changes my triage. @davidzollo to keep this simple to act on, the two blockers together are small, localized fixes: `Pattern.quote()` (or equivalent) on the per-split `table.include.list` value in `PostgresSourceFetchTaskContext.createConnectorConfig()`, and re-validating `slot.name` against `SLOT_NAME_PATTERN` after the `dbzProperties` merge in `PostgresSourceConfigFactory` the same way `include.schema.changes` is already re-applied post-merge. Once those land with the tests SEZ9 and I both asked for, and CI is green off a synced `dev`, I'm ready to re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
