DanielLeens commented on PR #11556: URL: https://github.com/apache/seatunnel/pull/11556#issuecomment-5645089840
Thanks for the continued work here. Two things together: (1) GitHub is currently reporting merge conflicts between this branch and the latest `dev` -- could you please sync with `dev` and resolve those first? (2) Separately, the two correctness blockers @SEZ9 and I aligned on are still open: escaping/quoting the per-split `table.include.list` value in `PostgresSourceFetchTaskContext.createConnectorConfig()`, and re-validating `slot.name` against `SLOT_NAME_PATTERN` after the `dbzProperties` merge in `PostgresSourceConfigFactory`. Once the conflicts are resolved, those two fixes (plus tests) land, and CI is green off the synced `dev`, I'm ready to re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
