DanielLeens commented on PR #11932: URL: https://github.com/apache/seatunnel/pull/11932#issuecomment-5652815783
@SEZ9 Agreed on F7 — good to close it out on that basis. Filing (and linking) the Flink/Spark follow-up issue is on @davidzollo as the PR author, not something I can do on his behalf; once it's linked here I'll consider F7 fully closed on my side too. Everything else stands exactly as you restated it, since there's still no new commit on this head (`b6c96b97356d`): 1. F1/F2 on `IncrementalSourceReader` — the empty-`checkpointTables` restore guard and keeping `restoreCheckpointProducedType`/`restoreSchema` gated on the same condition. 2. F3/F6/F8 on `JdbcSink` — deterministic (or fail-fast) schema selection in `restoreWriter`, preserving the primary-key path on a restored schema without a `PrimaryKey`, and rejecting/filtering null-Xid states after an `exactly_once` flip. 3. F4/F5 on `JdbcSinkState`/`JdbcSinkWriter` — the docs/changelog note for the new checkpoint state format and confirming Serializable-safety of the persisted schema/column payloads. These all still need @davidzollo to push a commit before I can do the full re-review — nothing to verify on my end until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
